Re: make modules_install fails with latest fileutils

[Marcel J.E. Mol]

On Wed, Nov 21, 2001 at 11:52:26AM +1100, Keith Owens wrote:
> On Tue, 20 Nov 2001 19:38:20 +0100, 
> "Marcel J.E. Mol" <[e-mail]> wrote:
> >Just had some problems doing a modules_install with
> >fileutils-1.1.1-1 (redhat rawhide). The cp command
> >in there gives a non-zero return value when it is asked
> >to copy the same file in the argument list:
> >
> >--- Rules.make.org	Tue Nov 20 19:36:16 2001
> >+++ Rules.make	Mon Nov 19 23:48:03 2001
> >@@ -173,7 +173,7 @@
> > _modinst__: dummy
> > ifneq "$(strip $(ALL_MOBJS))" ""
> > 	mkdir -p $(MODLIB)/kernel/$(MOD_DESTDIR)
> >-	cp -f $(ALL_MOBJS) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
> >+	-cp -f $(ALL_MOBJS) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
> > endif
> 
> (1) Complain to the fileutils maintainer for introducing incompatible
>     behaviour.

Or to RedHat who introduced this fileutils in their tree (but then again,
it is Rawhide so I have nothing to complain about :-)

> (2) The correct workaround is
>      cp -f $(sort $(ALL_MOBJS)) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)

shouldn't this then be 'sort -u'.

-Marcel
-- 
     ======--------         Marcel J.E. Mol                MESA Consulting B.V.
    =======---------        ph. [phone]          P.O. Box 112
    =======---------        [e-mail]                 2630 AC  Nootdorp
__==== www.mesa.nl ---____U_n_i_x______I_n_t_e_r_n_e_t____ The Netherlands ____
 They couldn't think of a number,           Linux user 1148  --  counter.li.org
    so they gave me a name!  -- Rupert Hine  --  www.ruperthine.com