Re: [BUG] Bad #define, nonportable C, missing {}

[Tim Waugh]

--R8vV2+AjVNGd/4x/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 21, 2001 at 12:40:17PM +0000, vda wrote:

> drivers/block/paride/pf.c:      if (l==0x20) j--; targ[j]=0;
> drivers/block/paride/pg.c:      if (l==0x20) j--; targ[j]=0;
> drivers/block/paride/pt.c:      if (l==0x20) j--; targ[j]=0;
>     (these files need Lindenting too)
> ----------
> Missing {}
> Either a bug or a very bad style (so bad that I can even imagine
> that it is NOT a bug). Please double check before applying the patch!

This seems to be just bad indentation rather than a bug. 'targ[j]=0'
seems to have the purpose of zero-terminating the string, if you look
at the callers of those functions. (But yes, the code is extremely
hard to read, and I can't convince myself either way about whether the
|| two lines earlier should or shouldn't be an &&.)

Tim.
*/

--R8vV2+AjVNGd/4x/
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7+4z+yaXy9qA00+cRAmCuAJ9IkLsbtSQcgEDuVAJvTpdgMNLRjQCeINaM
CQQKEcxY3yHdyZb3fx0d40M=
=+LrR
-----END PGP SIGNATURE-----

--R8vV2+AjVNGd/4x/--