Re: 2.4.15-pre1: "bogus" message with reiserfs root and other weirdness

[Hans Reiser]

Christian Bornträger wrote:

>>>Machine booted ok and everything seemed to be ok, but i noticed a few
>>>weird messages in boot messages right before mounting the root-partition:
>>>FAT: bogus logical sector size 0
>>>FAT: bogus logical sector size 0
>>>
>>When the kernel is booting, it doesn't know the filesystem type of the
>>root fs, so it tries to mount the root device using all of the compiled-in
>>fs drivers, in the order they are listed in fs/Makefile.in.
>>It appears that the fat driver doesn't even check for a magic when it
>>starts trying to mount the filesystem, so it proceeds directly to
>>
>
>To be complete we should also apply this patch.
>
>diff -urN linux/fs/fat/inode.c linux-new/fs/fat/inode.c
>--- linux/fs/fat/inode.c        Thu Oct 25 09:02:26 2001
>+++ linux-new/fs/fat/inode.c    Wed Nov 21 21:28:49 2001
>@@ -609,7 +609,8 @@
>                CF_LE_W(get_unaligned((unsigned short *) &b->sector_size));
>        if (!logical_sector_size
>            || (logical_sector_size & (logical_sector_size - 1))) {
>-               printk("FAT: bogus logical sector size %d\n",
>+               if (!silent)
>+                   printk("FAT: bogus logical sector size %d\n",
>                       logical_sector_size);
>                brelse(bh);
>                goto out_invalid;
>@@ -618,7 +619,8 @@
>        sbi->cluster_size = b->cluster_size;
>        if (!sbi->cluster_size
>            || (sbi->cluster_size & (sbi->cluster_size - 1))) {
>-               printk("FAT: bogus cluster size %d\n", sbi->cluster_size);
>+               if (!silent)
>+                   printk("FAT: bogus cluster size %d\n", sbi->cluster_size);
>                brelse(bh);
>                goto out_invalid;
>        }
>
>
How about putting fat last in the list, and having it say something more 
like "FAT: bogus cluster size, perhaps XXX is not a FAT partition"