Re: [PATCH] Enhancement of /proc/partitions output (2.5.1-pre5)

Marcel J.E. Mol (marcel@mesa.nl)
Sat, 1 Dec 2001 21:51:46 +0100

On Sat, Dec 01, 2001 at 11:47:34AM +0000, Andries.Brouwer@cwi.nl wrote:
> From: Andreas Dilger <adilger@turbolabs.com>
>
> > Please consider below patch which adds the starting sector and number of
> > sectors to /proc/partitions.
>
> Please do not accept as-is. This breaks the format of /proc/partitions
> terribly, and all of the code that looks at it (fsck, mount, etc).
>
> Indeed.
>
> Rather add the start_sect and nr_sects parameters _after_ the name
> parameter, and it will be "mostly" ok.
>
> No. It will still break things.

Why, all fields are defined quite well. So usertools can easily get the info they
need based on 'column' number. If adding extra fields at the end breaks programs I
guess these tools should be fixed.

RedHat kernels already have extended /proc/partitions: the sar patches...
It would ne nice to add these to the 2.5 kernel.

-Marcel

-- 
     ======--------         Marcel J.E. Mol                MESA Consulting B.V.
    =======---------        ph. +31-(0)6-54724868          P.O. Box 112
    =======---------        marcel@mesa.nl                 2630 AC  Nootdorp
__==== www.mesa.nl ---____U_n_i_x______I_n_t_e_r_n_e_t____ The Netherlands ____
 They couldn't think of a number,           Linux user 1148  --  counter.li.org
    so they gave me a name!  -- Rupert Hine  --  www.ruperthine.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/