Re: PATCH 2.4.17.2: make ext2 smaller

[Ingo Oeser]

On Sun, Dec 02, 2001 at 10:54:34PM +1100, Keith Owens wrote:
> On Sun, 02 Dec 2001 06:31:17 -0500, 
> Jeff Garzik <[e-mail]> wrote:
> >Simply, all ext2 files are #include'd into a single file, ext2_all.c,
> >and all functions and data structures are declared static.
> 
> I like it.

Me also. Except for the KSTATIC spread all over the Kernel.

> With kbuild 2.5 the generation of ext2_all.c (I prefer
> ext2_static.c) can be automated.
> 
> The code that is normally linked into xxxx.o has to be manually changed
> to add XXXX_STATIC before a make_static(xxxx) command can be added.

Even this doesn't have to be done manually. Everything that is
not covered by EXPORT_SYMBOL() in this case can be static, since
it belongs only to this subsystem and is not oficially exported
to other ones, which is a BUG if something depend on it with
CONFIG_MAKE_STATIC enabled.

Now if GCC had an option to make all symbols static by default,
which are not also declared extern...

Regards

Ingo Oeser
-- 
Science is what we can tell a computer. Art is everything else. --- D.E.Knuth