Re: Fwd: binutils in debian unstable is broken.

Jeff Garzik (jgarzik@mandrakesoft.com)
Wed, 05 Dec 2001 09:18:34 -0500


Eric Lammerts wrote:
> change the drivers like this:
>
> #ifdef DEVEXIT_LINKED
> remove: firestream_remove_one,
> #endif
>
> to this:
>
> remove: DEVEXIT_FUNC(firestream_remove_one),

The overall situation is not great, but I think I prefer this, or
something like this, to the ifdef.

I'm tempted to say we should add a per-driver function that calls BUG()
instead of a generic function which calls panic(), though. That will be
a bit more informative to users. For the case where the real
xxx_remove_one is dropped, it is a kernel bug if that code is -ever-
called...

Jeff

-- 
Jeff Garzik      | Only so many songs can be sung
Building 1024    | with two lips, two lungs, and one tongue.
MandrakeSoft     |         - nomeansno

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/