Re: Fwd: Hard Lockup on 2.4.16 with Via ieee1394 (sbp2 mode)

[Matthew Dharm]

--5vNYLRcllDrimb99
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

It should be using scsi_done()... it actually seems to use whatever was
given as a done function at the queuecommand point, which is, I think,
scsi_done().

Matt

On Fri, Dec 28, 2001 at 08:59:17PM -0800, Andrew Morton wrote:
> Matthew Dharm wrote:
> >=20
> > Hrm...
> >=20
> > Does this apply to usb-storage also?  Under what conditions do you need=
 to
> > hold the io_request_lock when calling the done function?
> >=20
>=20
> That's scsi_old_done().  I don't think scsi_done() cares whether
> io_request_lock is held or not.
>=20
> And io_request_lock *must* be held by the caller of scsi_old_done() - it
> assumes this.   I think we'd have heard by now if usb was getting this
> wrong.  Looks like it's using scsi_done(), yes?
>=20
> -

--=20
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.=
net=20
Maintainer, Linux USB Mass Storage Driver

Sir, for the hundreth time, we do NOT carry 600-round boxes of belt-fed=20
suction darts!
					-- Salesperson to Greg
User Friendly, 12/30/1997

--5vNYLRcllDrimb99
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8LVBxz64nssGU+ykRAjKjAJ0QbPaYwuiHSil/3OUjvwQhiL3C2ACg9AIW
KyU3J37Ht9DA4gKcqaHIyog=
=wVod
-----END PGP SIGNATURE-----

--5vNYLRcllDrimb99--