Re: Fwd: Hard Lockup on 2.4.16 with Via ieee1394 (sbp2 mode)

[Timothy Covell]

On Friday 28 December 2001 21:51, you wrote:
> Timothy Covell wrote:
> > lockup
> > ...
> > sbp2
> > ...
> > SMP
> > ...
>
> --- linux-2.4.17-pre8/drivers/ieee1394/sbp2.c	Mon Dec 10 13:46:20 2001
> +++ linux-akpm/drivers/ieee1394/sbp2.c	Wed Dec 12 20:50:16 2001
> @@ -2773,7 +2773,9 @@ static void sbp2scsi_complete_command(st
>  	/*
>  	 * Tell scsi stack that we're done with this command
>  	 */
> +	spin_lock_irq(&io_request_lock);
>  	done (SCpnt);
> +	spin_unlock_irq(&io_request_lock);
>
>  	return;
>  }
>
> 

That did the trick. I'm writing this on 2.4.16-ctx4 with this patch on SMP.
It's amazing what a little spin lock will do.  Thanks!

(Even if I had realized that this was fixed on 2.4.17, I had other issues
with 2.4.17 which prevented me from wanting to run it.)

[e-mail].