Re: [PATCH] New per-cpu patch v2.5.1

Rusty Russell (rusty@rustcorp.com.au)
Thu, 27 Dec 2001 17:50:33 +1100


On Thu, 20 Dec 2001 17:43:35 +0530
Dipankar Sarma <dipankar@in.ibm.com> wrote:

> Hi Rusty,
>
> I appreciate the noble gesture of allowing NUMA people to
> locate the per-cpu areas in different places in memory ;-)
>
> That said, memcpy of static per-cpu areas doesn't seem right.
> Why copy the same area to all the dynamically allocated per-cpu
> areas ?

Initialization. Sure, we can't do it with the current macros...

> Also, shouldn't the size be &__per_cpu_end - &__per_cpu_start ?

Oops... Yes. (I wrote this just before my Xmas break, and didn't have time
to test it).

> And how do we use this with per-cpu data used right
> from smp boot, say apic_timer_irqs[] ?

No. You can't have everthing (without going into the arch-specific code).

Cheers,
Rusty.

-- 
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/