[PATCH, COMPILE-FIX, TYPO] drivers/char/pc110pad.c

Manfred Spraul (manfred@colorfullife.com)
Sun, 30 Dec 2001 14:15:56 +0100


This is a multi-part message in MIME format.
--------------DAFE3B0BD61F57FF51FCB700
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

pc110pad.c doesn't compile if SMP is enabled. This patch is needed:
<<<<<<
--- 2.5/drivers/char/pc110pad.c Sat Dec 29 19:13:41 2001
+++ build-2.5/drivers/char/pc110pad.c Sun Dec 30 14:02:32 2001
@@ -590,7 +590,7 @@
spin_lock_irqsave(&pc110_lock, flags);
if (!--active_count)
outb(0x30, current_params.io+2); /* switch off
digitiser */
- spin_unlock_irqrestore(&active_lock, flags);
+ spin_unlock_irqrestore(&pc110_lock, flags);
return 0;
}

<<<<<<<<<

The bug was introduced between 2.4.17 and 2.5.1: someone added
spinlocks instead of cli(), without adding his name to the changelog.

--
	Manfred
P.S.: Netscape eats space, I've attached is as MIME, too.
--------------DAFE3B0BD61F57FF51FCB700
Content-Type: text/plain; charset=us-ascii;
 name="patch-pc110"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="patch-pc110"

--- 2.5/drivers/char/pc110pad.c Sat Dec 29 19:13:41 2001 +++ build-2.5/drivers/char/pc110pad.c Sun Dec 30 14:02:32 2001 @@ -590,7 +590,7 @@ spin_lock_irqsave(&pc110_lock, flags); if (!--active_count) outb(0x30, current_params.io+2); /* switch off digitiser */ - spin_unlock_irqrestore(&active_lock, flags); + spin_unlock_irqrestore(&pc110_lock, flags); return 0; }

--------------DAFE3B0BD61F57FF51FCB700--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/