Re: [RFC] [WIP] Unbork fs.h, 3 of 3

Arnaldo Carvalho de Melo (acme@conectiva.com.br)
Mon, 31 Dec 2001 17:01:25 -0200


Em Mon, Dec 31, 2001 at 10:16:14AM -0800, Linus Torvalds escreveu:
> How about using a descriptor structure instead of the macro, and making
> the filesystem declaration syntax look more like
>
> static struct file_system_type ext2_descriptor = {
> owner: THIS_MODULE,
> fs_flags: FS_REQUIRES_DEV,
> name: "ext2",
> read_super: ext2_read_super,
> sb_size: sizeof(ext2_sb_info),
> inode_size: sizeof(struct ext2_inode_info)
> };
>
> which is more readable, and inherently documents _what_ those things are.

Agreed, this is how the other structs of similar purpose (proto_opts,
net_proto_family, etc) are initialized.

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/