Re: Patch?: linux-2.5.2-pre9/drivers/block/ll_rw_blk.c blk_rq_map_sg simplification

[Adam J. Richter]

>>> = Adam Richter ([e-mail])
>>  = Jens Axboe ([e-mail])
>   = Dave Jones ([e-mail])
>>> 	The following patch removes gotos from blk_rq_map_sg, making
>>> it more readable and five lines shorter.  I think the compiler should
>>> generate the same code.  I have not tested this other than to
>>> verify that it compiles.
>> Well, I really think the original is much more readable than the changed
>> version :-)

>I agree. Upon seeing the patch, I was reminded of the monster
>enormous conditional at http://gcc.gnu.org/projects/beginner.html
>not quite _that_ bad, but getting there 8)

	The conditional is one level deep (it's just a list of
"and" conjunctions) and has a single conceptual meaning, "are
the segments joinable?"  For what it's worth, I really could not
understand the old version until I rewrote it without gotos.

Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104
[e-mail]     \ /                  San Jose, California 95129-1034
[phone]         | g g d r a s i l   United States of America
fax [phone]      "Free Software For The Rest Of Us."