Re: [PATCH] Compilation error on 2.5.10 linux-2.5/drivers/ide/pdc4030.c

[Zwane Mwaikambo]

>This fixes an error when compiling and removes a unused variable warning
>The following warning I'm not sure about though:
>
>pdc4030.c: In function `do_pdc4030_io':
>pdc4030.c:571: warning: control reaches end of non-void function

That warning is because the function returns an ide_startstop_t but there
is no ending return statement. Looking at the code it is possible to
reach that particular code path. Mind doing a quick patch?

ide_startstop_t do_pdc4030_io (ide_drive_t *drive, struct request *rq)
{
<snip>
    default:
                printk(KERN_ERR "pdc4030: command not READ or WRITE!
Huh?\n");
                ide_end_request(0, HWGROUP(drive));
                break;
        }
	<=== [1]
}

[1] No return statement here but function is non-void (ie it should return
something)