Re: acquire_console_sem exported, but not release_console_sem?

[Andrew Morton]

"Michael C. Toren" wrote:
> 
> Hi,
> 
> In kernel/printk.c, it looks like acquire_console_sem() is exported, but
> not release_console_sem()?  Is this intentional, or just an oversight?

Oversight.  It's possible that some modular video drivers will need
to acquire this lock, so it should be exported.  At this time, it's
only fbcon.c and that code doesn't support modular linkage, so
nobody has noticed.

--- linux-2.4.18-pre3/kernel/printk.c	Thu Jan 10 13:39:50 2002
+++ linux-akpm/kernel/printk.c	Sat Jan 12 19:32:50 2002
@@ -529,6 +529,7 @@ void release_console_sem(void)
 	if (must_wake_klogd && !oops_in_progress)
 		wake_up_interruptible(&log_wait);
 }
+EXPORT_SYMBOL(release_console_sem);
 
 /** console_conditional_schedule - yield the CPU if required
  *