Re: [PATCH][RFC] unchecked request_region's in drivers/net

[Alan Cox]

> Any objection to this being merged in both 2.4 and 2.5?

It would be nice to get them correct first. Can you split out the ones which
just fix

	if (check_region....)
	{
	}
	request_region

with no intervening logic and submit those first ?

> -	if (check_region(dev->base_addr, SER12_EXTENT))
> +	if (!request_region(dev->base_addr, SER12_EXTENT,
> +				"baycom_ser_fdx"))
>  		return -EACCES;
>  	memset(&bc->modem, 0, sizeof(bc->modem));
>  	bc->hdrv.par.bitrate = bc->baud;
> @@ -431,7 +432,6 @@
>  	if (request_irq(dev->irq, ser12_interrupt, SA_INTERRUPT | SA_SHIRQ,
>  			"baycom_ser_fdx", dev))
>  		return -EBUSY;

This path fails to free the region

>  	if (request_irq(dev->irq, ser12_interrupt, SA_INTERRUPT | SA_SHIRQ,
>  			"baycom_ser12", dev))
>  		return -EBUSY;
> -	request_region(dev->base_addr, SER12_EXTENT, "baycom_ser12");

Ditto

> -		}
>  		if (request_irq(dev->irq, COMX_interrupt, 0, dev->name, 
>  		   (void *)dev)) {
>  			printk(KERN_ERR "comx-hw-comx: unable to obtain irq %d\n", dev->irq);
>  			return -EAGAIN;

Ditto

>  	for (; (i < maxSlots) && (dev != NULL); iobase += EWRK3_IOP_INC, i++) {
> -		if (!check_region(iobase, EWRK3_TOTAL_SIZE)) {
> +		if (request_region(iobase, EWRK3_TOTAL_SIZE, dev->name)) {
>  			if (DevicePresent(iobase) == 0) {

Here you keep forgeting to free the regions

> diff -Nru clean-2.4.17//drivers/net/wan/sealevel.c linux/drivers/net/wan/sealevel.c
> --- clean-2.4.17//drivers/net/wan/sealevel.c	Mon Nov  5 19:23:14 2001
> +++ linux/drivers/net/wan/sealevel.c	Thu Dec 27 14:18:21 2001
> @@ -219,12 +219,11 @@
>  	 *	Get the needed I/O space
>  	 */
>  	 
> -	if(check_region(iobase, 8))
> +	if(!request_region(iobase, 8, "Sealevel 4021"))
>  	{	
>  		printk(KERN_WARNING "sealevel: I/O 0x%X already in use.\n", iobase);
>  		return NULL;
>  	}
> -	request_region(iobase, 8, "Sealevel 4021");
>  	
>  	b=(struct slvl_board *)kmalloc(sizeof(struct slvl_board), GFP_KERNEL);
>  	if(!b)

This one I'm maintainer of and approve