Re: [PATCH] Rx FIFO Overrun error found

[Jeff Garzik]

Manfred Spraul wrote:
> 
> Hi all,
> 
> I think I found the reason for the Rx status FIFO overrun nic hang:
> If the Rx fifo overflows, the nic sets RxStatusFIFOOver _instead_ of
> IntrRxIntr.
> Thus netdev_rx is never called, the rx ring is never refilled, nic
> hangs.
> 
> The attached patch adds proper OOM handling to natsemi.c.
> I've also copied the simpler netdev_close locking from ns83820.c.

Two comments, sis900.c uses the check (rx-overrun | rx-err | rx-ok), did
you test that combination?  (s/RxStatusFIFOOver/IntrRxOverrun/)

and it would be preferred to separate "add oom handling" and "fix nic
hang" patches.

-- 
Jeff Garzik      | Alternate titles for LOTR:
Building 1024    | Fast Times at Uruk-Hai
MandrakeSoft     | The Took, the Elf, His Daughter and Her Lover
                 | Samwise Gamgee: International Hobbit of Mystery