Re: [PATCH] fix two bugs in lib/vsprintf.c

Michal Jaegermann (michal@harddata.com)
Tue, 15 Jan 2002 17:20:10 -0700


On Tue, Jan 15, 2002 at 01:25:38AM -0800, Roland Dreier wrote:
> The below patch fixes two bugs in lib/vsprintf.c's implementation of
> vsscanf().

If we are looking at these things I have some gnawing suspicions
that a constant 0xFFFFFFFFUL at line 489 of lib/vsprintf.c
in this function:

int vsprintf(char *buf, const char *fmt, va_list args)
{
return vsnprintf(buf, 0xFFFFFFFFUL, fmt, args);
}

was really meant to be (size_t)(-1). It is not the same if a platform
is not 32 bits. Roland, what do you think?

Michal
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/