Re: [PATCH] 2.5.3 remove global semaphore_lock spin lock.

[Jeff Garzik]

On Thu, Jan 31, 2002 at 03:55:02PM -0800, Andrew Morton wrote:
> > +       unsigned long flags;
> > +       wq_write_lock_irqsave(&sem->wait.lock, flags);
> > -       spin_lock_irq(&semaphore_lock);
> 
> I rather dislike spin_lock_irq(), because it's fragile (makes

It's less flexible for architectures, too.

spin_lock_irqsave is considered 100% portable AFAIK, and I make it my
own policy to s/_irq/_irqsave/ when the opportunity strikes in my PCI
drivers.

	Jeff