Re: [PATCH][RFC] kthread abstraction

[Christoph Hellwig]

On Fri, Feb 01, 2002 at 05:50:33PM +0100, Andi Kleen wrote:
> Christoph Hellwig <[e-mail]> writes:
> 
> 	
> >     void *data;
> > 
> > 	Opaque data for the thread's use.
> 
> That requires to dynamically allocate and initialize kthread if you
> can have potentially multiple threads (= too much to write) 
> 
> I think it would be better to pass data as a separate argument.
> You can put the kthread and the data into a private structure on
> the stack, pass the address of it to kernel_thread and wait until the 
> thread has read it using a completion. 

Agreed.  I will rework the patch to follow your suggestion.

	Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.