Re: [PATCH] -- filesystems.c::sys_nfsservctl

Trond Myklebust (trond.myklebust@fys.uio.no)
13 Feb 2002 22:26:35 +0100


>>>>> " " == Craig Christophel <merlin@transgeek.com> writes:

> Ok guys get ready to flame me....
> The attached patch removes the lock/unlock in this function.
> Now I am 80%
> sure of this one, but would like a word from the kmod
> maintainer about whether request_module needs the BKL or not.
> do_nfsservctl already takes the BKL inside the function so as
> long as request_module is safe this pair can be removed --
> effectively making do_nfsservctl responsible for it's own
> locking scheme.

What would remain to protect 'nfsd_linkage' if you removed the BKL?

Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/