Re: extending callbacks?

[Eric W. Biederman]

Matthias Scheidegger <[e-mail]> writes:

> Hi,
> 
> I've got the following problem: I want to register a callback in a kernel
> structure, but I need to supply an additional argument to my own code. I.e. I
> need a callback
> 
> int (*cb)(int u)
> 
> to really call
> 
> int (*real_cb)(int u, void* my_arg)
> 
> At the moment, I'm only focussing on the i386 architecture.
> In user space, I'd do this by generating some machine code, which takes the
> original args, pushes my_fixed_arg and calls real_cb (using mprotect to make
> the generated code callable). That way I'd use a function
> 
> int (*)(int) create_callback(int (*real_cb)(int, void*), void *arg);
> 
> Is there a good way to do that in the kernel?
> Not necessarily using self modifying code, I'll only use it if I must.

The general case requires self modifying code.  Where do you need this in the
kernel.  For most callbacks the kernel is already passing a fairly generic
parameter you can use.  So this trick should be unnecessary.  

In general it would be better to modify what the kernel is passing the function
than to build up an infrastructure to avoid fixing the code.  Especially
as runtime generated code tends to have a performance penalty.

Eric