> Indeed, I suspect you'll want to either fix this or remove
> the code before submitting the patch. Including dead code
> right from the start seems kind of pointless.
Fix it is obviously the right way to go, assuming it is really broken
rather than some problem in the breakup.
> Note that if you have the ndirty thing functional, the
> nfract_stop_bdflush tunable isn't doing anything, since
> kswapd would stop after ndirty pages ...
That's not the intent... one is "don't do too much at one time" and the
other is "stop when you've done enough." I think both are good things to
be able to adjust, along with the usual frequency of check and age to
flush. Better that all of these should WORK, of course.
-- bill davidsen <davidsen@tmr.com> CTO, TMR Associates, Inc Doing interesting things with little computers since 1979.- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/