[PATCH] 2.4.19-pre3 - readv/writev should return EINVAL for count=0

Paul Larson (plars@austin.ibm.com)
20 Mar 2002 12:53:47 -0600


This is a minor patch against 2.4.19-pre3 for readv/writev to have it
return EINVAL if count=0 is passed to it. According to the man page and
also the specifications for readv/writev, this is the correct behaviour.

Thanks,
Paul Larson

Index: linux24/fs/read_write.c
diff -u linux24/fs/read_write.c:1.1.1.1 linux24/fs/read_write.c:1.1.1.1.2.1
--- linux24/fs/read_write.c:1.1.1.1 Wed Mar 20 12:00:25 2002
+++ linux24/fs/read_write.c Wed Mar 20 12:19:06 2002
@@ -215,10 +215,9 @@
* First get the "struct iovec" from user memory and
* verify all the pointers
*/
- ret = 0;
+ ret = -EINVAL;
if (!count)
goto out_nofree;
- ret = -EINVAL;
if (count > UIO_MAXIOV)
goto out_nofree;
if (!file->f_op)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/