Re: [patch] smaller kernels

Rusty Russell (rusty@rustcorp.com.au)
Mon, 25 Mar 2002 16:56:05 +1100


On Tue, 19 Mar 2002 22:11:48 -0800
Andrew Morton <akpm@zip.com.au> wrote:

> This is the result of a search-and-destroy mission against
> oft-repeated strings in the kernel text. These come about
> due to the toolchain's inability to common up strings between
> compilation units.

The name is horrible. BUG() stands out: perhaps "BUG_LITE()"?

And I'm not sure DaveM'll appreciate this:

> static inline char *__skb_pull(struct sk_buff *skb, unsigned int len)
> {
> skb->len-=len;
> - if (skb->len < skb->data_len)
> - BUG();
> return skb->data+=len;
> }

Rusty.

-- 
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/