Re: Linux 2.4.19pre4-ac1

Bill Davidsen (davidsen@tmr.com)
Wed, 27 Mar 2002 09:29:13 -0500 (EST)


On Wed, 27 Mar 2002, Neil Brown wrote:

> I think I felt that macros would be very noisy for relatively little
> gain.
> However I guess
>
> #define ST 1 /* status*/
> #define FH 17 /* filehandle with length */
> #define AT 22 /* attributes */
> #define WC 7 /* WCC attribute prefix */
>
> might make things clearer without being too noisy....

A true member of the "never use a long name when a short one will do"
school? You really could sacrifice a few more bytes and use more
descriptive names which mean something without looking at the macro
definition...

Whatever, coding style is personal, I make mine as readable as possible
because the next person struggling to understand it in a few years is
likely to still be me.

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/