Re: proc_file_read() hack?

Todd Inglett (tinglett@vnet.ibm.com)
Thu, 28 Mar 2002 09:29:55 -0600


Thomas Hood wrote:

>>If that is true I am wondering how it could possibly be correct
>>since start will be used as a length which is greater than the
>>size of the page.
>>
>
> start will be used as an offset, not as a length.
>
> If you think the hack was a bad idea, I agree with you.
> But we can't change it without auditing all the proc read
> functions that use case #1.

Ahh...thanks for taking the trouble to answer all these questions :). I
obviously wasn't paying attention enough to see that start was *not*
used as a length. Sigh. Anyway, yes I agree we cannot patch this
without some serious review and I'm not going to volunteer today :).

-todd

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/