Re: 2.5.7 pre-UDMA PIIX bug

Martin Dalecki (dalecki@evision-ventures.com)
Sat, 30 Mar 2002 15:26:36 +0100


Bill Davidsen wrote:
> On Fri, 29 Mar 2002, Martin Dalecki wrote:
>
>
>>> 333 T = 1000000000 / piix_clock;
>>> 334 UT = T / umul;
>>
>>I think that it should be just sufficient to add the
>>following test just in front of the offending calculartion.
>>
>>if (umul == 0)
>> ++umul;
>
>
> - 334 UT = T / umul;
> + 334 UT = T / (umul || 1);

That is ceratily wrong. becouse umul || 1 == 1 independently
from umul.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/