Re: linux-2.5.7

[Andrew Morton]

Alexander Viro wrote:
> 
> ...
> +/*
> + * "Conditional" syscalls
> + *
> + * What we want is __attribute__((weak,alias("sys_ni_syscall"))),
> + * but it doesn't work on sparc64, so we just do it by hand
> + */
> +#define cond_syscall(x) asm(".weak\t" #x "\n\t.set\t" #x ",sys_ni_syscall");
> +
> +cond_syscall(sys_nfsservctl)
> +cond_syscall(sys_quotactl)
> +cond_syscall(sys_acct)
> +

Could you remind us what problem this is solving?  The
#ifdef approach seemed reasonable and there's no indication
here why weak linkage is needed.

Weak linkage could perhaps be useful elsewhere.  Maybe this
should be implemented as

	weak_symbol(sym, default_sym)

in some generic header somewhere...

-