Re: [PATCH] : ir257_usb_disconnect_atomic-2.diff

Greg KH (greg@kroah.com)
Tue, 2 Apr 2002 19:00:38 -0800


On Tue, Apr 02, 2002 at 06:24:13PM -0800, Jean Tourrilhes wrote:
> @@ -1519,33 +1544,47 @@ static void *irda_usb_probe(struct usb_d
> /*
> * The current irda-usb device is removed, the USB layer tell us
> * to shut it down...
> + * One of the constraints is that when we exit this function,
> + * we cannot use the usb_device no more. Gone. Destroyed. kfree().
> + * Most other subsystem allow you to destroy the instance at a time
> + * when it's convenient to you, to postpone it to a later date, but
> + * not the USB subsystem.
> + * So, we must make bloody sure that everything gets deactivated.
> + * Jean II

That's one of the next things I'm going to be working on fixing :)

The patch looks good. Thanks for setting the proper GFP_* flag.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/