Re: 3c59x.c - kernel message explosion (fwd)

Denny Gudea (ekay@ecs.fullerton.edu)
Wed, 3 Apr 2002 16:08:45 -0800 (PST)


you are correct.. i am a newbie.. my debug is set to the default (1)i
didnt see that last vortex_debug..

the machine i have this nic on visits several networks.. as this code
suggests, maybe this is a more serious error than i thought. this machine
has been tested in several networks, and seems to be happening everywhere
for me.

can you guys give me any clues to finding the culprit on the
network? the condition is easily created for me..

thanks for your help

denny gudea
ekay@ecs.fullerton.edu

On Wed, 3 Apr 2002, Jeff Garzik wrote:

> Denny Gudea wrote:
> > i believe the problem resides when it tests for the debug level:
> >
> > if (vortex_debug > 2
> > || (tx_status != 0x88 && vortex_debug > 0)) {
> >
> > the || operator should be a && because we only want to print the error
> > message if debug is greater than 2 and the transmit status is not what it
> > should be.
>
>
>
> the test looks ok... it prints if the status is not what it should be,
> if vortex_debug is 1 or 2, and unconditionally prints the status if
> vortex_debug is 3 or greater.
>
> What is your vortex_debug setting?
>
> Jeff
>
>
>
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/