Re: Linux-2.5.8-pre1

Tim Schmielau (tim@physik3.uni-rostock.de)
Thu, 4 Apr 2002 13:45:19 +0200 (CEST)


On Thu, 4 Apr 2002, Martin Dalecki wrote:

> By just reading the patch I have came across the following code:
>
> diff -Nru a/arch/cris/drivers/ethernet.c b/arch/cris/drivers/ethernet.c
> --- a/arch/cris/drivers/ethernet.c Wed Apr 3 17:11:15 2002
> +++ b/arch/cris/drivers/ethernet.c Wed Apr 3 17:11:15 2002
> ......
>
> @@ -1313,7 +1313,7 @@
> static void
> e100_clear_network_leds(unsigned long dummy)
> {
> -
> if (led_active && jiffies > led_next_time) {
> +
> if (led_active && jiffies > time_after(jiffies, led_next_time)) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This should almost certainly be instead:
>
> +
> if (led_active && time_after(jiffies, led_next_time)) {
> !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Yes, my mistake. Please correct.

Tim (wondering how this patch made it into 2.5.8-pre1)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/