Re: BKL in tiglusb release function

[Dave Hansen]

Romain Liévin wrote:
 > I have followed examples from other codes such as dabusb.c &
 > printer.c (2.4.14). After a further look: - dabusb.c from 2.4.14
 > contains a kernel_lock/unlock couple only in _release but it has
 > been removed in 2.5.7 - printer.c contains a kernel_lock/unlock
 > couple in _open & _release in both 2.4.14 and 2.5.7

I was probably responsible for the removal from dabusb.c.  In almost all
cases that I found (over 60 of them), the BKL is not needed in the 
release function.

The use of s->mutex confuses me.  In tiglusb_disconnect(), there is an 
up().  Where is the matching down?  The comment for the mutex just says, 
"locks this struct".  However, it is clear that it doesn't protect the 
whole structure.  There are many places where structure members are 
accessed without the lock being held.

-- 
Dave Hansen
[e-mail]