Re: readahead

Jens Axboe (axboe@suse.de)
Tue, 16 Apr 2002 21:33:04 +0200


On Tue, Apr 16 2002, Andrew Morton wrote:
> Andries.Brouwer@cwi.nl wrote:
> >
> > ...
> > Do these cards not have a request queue?
> >
> > The kernel views them as SCSI disks.
> > So yes, I can do
> >
> > blockdev --setra 0 /dev/sdc
> >
> > Unfortunately that does not help in the least.
> > Indeed, the only user of the readahead info is
> > readahead.c: get_max_readahead() and it does
> >
> > blk_ra_kbytes = blk_get_readahead(inode->i_dev) / 2;
> > if (blk_ra_kbytes < VM_MIN_READAHEAD)
> > blk_ra_kbytes = VM_MAX_READAHEAD;
> >
> > We need to distinguish between undefined, and explicily zero.
>
> Yup. The below (untested) patch should fix it up. Assuming
> that all drivers use blk_init_queue(), and heaven knows if
> that's the case. If not, the readahead window will have to be

set it in blk_queue_make_request(), please.

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/