Re: [BK PATCH] USB device support for 2.5.8 (take 2)

[Greg KH]

On Tue, Apr 16, 2002 at 09:35:33PM -0700, Linus Torvalds wrote:
> 
> 
> On Tue, 16 Apr 2002, Greg KH wrote:
> >
> > Linus, here is an updated changeset series with the USB device support.
> 
> Since I haven't pulled any of the usb device updates yet, might I suggest:
> 
>  - redoing the BK archive completely without the broken series (ie an
>    actual "bk undo")

Well since you don't want to pull it, I can just trash this tree, it
only contains the Lineo code.

>  - explaining to me what a "usb device" is, that isn't a normal USB
>    device? Why is "usb/device/xxx" different from the existing USB device
>    drivers?

It's code to be a USB client device, not a USB host device, which is
what we currently have.  It is used in embedded devices that run Linux,
like the new Sharp device (can't remember the name right now...)

> In other words, please explain what the _point_ of this code is?
> Especially since the code is obvious crap, from the little I looked at it,
> and quite frankly my immediate reaction is that it shouldn't get even
> _close_ to the kernel before it has gone through some _major_ cleanup.
> 
> Let's face it, look at the absolute SHIT in usbd-debug.c, where somebody
> has re-created strcmp/strcpy/etc, except with stupid names, and bad
> implementation.
> 
> In short, I refuse to pull this crap. The people who wrote it were either
> on drugs, incompetent, or just plain crazy. "Just say no".

Sorry.  I spend most of my time on this code just cleaning the format
and removing build errors, instead of looking at the content :(

I'll work on fixing all of the crap before submitting it again.

thanks,

greg k-h