Re: [PATCH] x86 boot enhancements, boot bean counting 8/11

[Martin Dalecki]

Eric W. Biederman wrote:
> Linus please apply,
> 
> Rework the actual build/link step for kernel images.  
> - remove the need for objcopy
> - Kill the ROOT_DEV Makefile variable, the implementation
>   was only half correct and there are much better ways
>   to specify your root device than modifying the kernel Makefile.
> - Don't loose information when the executable is built

Coudl you please use sufficiently large fields for kdev_t variables?
This way if we once have bigger device id spaces one will not have
to mess with the boot code again.
Thank you.

> +
> +struct boot_params {
> +	uint8_t  reserved1[0x1f1];		/* 0x000 */
> +	uint8_t  setup_sects;			/* 0x1f1 */
> +	uint16_t mount_root_rdonly;		/* 0x1f2 */
> +	uint16_t syssize;			/* 0x1f4 */
> +	uint16_t swapdev;			/* 0x1f6 */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
this should be uint32_t

> +	uint16_t ramdisk_flags;			/* 0x1f8 */
> +#define RAMDISK_IMAGE_START_MASK  	0x07FF
> +#define RAMDISK_PROMPT_FLAG		0x8000
> +#define RAMDISK_LOAD_FLAG		0x4000	
> +	uint16_t vid_mode;			/* 0x1fa */
> +	uint16_t root_dev;			/* 0x1fc */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
this should be uint32_t