Re: modversion.h improvement suggestion

Keith Owens (kaos@ocs.com.au)
Mon, 06 May 2002 09:43:00 +1000

On Sun, 5 May 2002 18:00:51 +0200,
Sebastian Huber <sebastian-huber@web.de> wrote:
>So what about a default modversion.h file:
>/* This is an automatically generated file. Do not edit it. */
>#error You have not generated the module versions. You have to ...

No.

It is a big mistake to ship a file and overwrite it under the same
name. It messes up source repositories.

Any code that has an explicit #include <linux/modversions.h> is broken.
The kernel build automatically includes modversions.h when required.

The build instructions for third party modules should say something
like

If your kernel was built with CONFIG_MODVERSIONS=y then add these
flags to the build for this module

-DMODVERSIONS -include kernel_source_tree/linux/modversions.h

In any case, modversions.h will disappear in kbuild 2.5.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/