Re: [PATCH] double flush_page_to_ram

[Hugh Dickins]

On Thu, 9 May 2002, Andrea Arcangeli wrote:
> 
> If yes, I prefer to move the flush_page_to_ram on the _pagecache_
> _before_ the memcpy into memory.c, it's cleaner if the pagecache layer
> doesn't need to care about cache aliasing between kernel direct mapping
> and userspace address space (but that it only cares about struct pages
> and filesystem, so only kernel side), and that such user-related part is
> covered only in memory.c.

Agreed.  It's better to keep flush_page_to_ram out of filemap_nopage
(and how many other _nopages that ought at present to have it according
to David, but don't).  As things stand, it's being done unnecessarily
twice on the shared maps: your proposal fixes that.

Hugh