Re: OOPS 2.4.19-pre7-ac4 (Was: strange things in kernel 2.4.19-pre7-ac4

Zwane Mwaikambo (zwane@linux.realnet.co.sz)
Mon, 13 May 2002 17:52:26 +0200 (SAST)


On Mon, 13 May 2002, Denis Vlasenko wrote:

> > I did use memtest86 and all test is passed, no errors.
> > And problem still persists with 2.4.19-pre8-ac2 ; oops
> > after exiting X
> >
> > Now I have to use 2.4.16 ; any way all kernel before
> > 2.4.19-pre2 is normal, I did not test 2.4.19-preX>2
> > but 2.4.19-pre7-ac4 and 2.4.19-pre8-ac2
>
> When no one answers on lkml to your oops report, you
> have basically the only choice: start looking at stack trace
> yourself, insert printks here and there, recompile and give it a try.

This looks fishy...

static void i810_free_page(drm_device_t *dev, unsigned long page)
{
struct page * p = virt_to_page(page);
if(page == 0UL)
return;

put_page(p);
unlock_page(p);
[...]

You get to unlock_page with p = %eax

void unlock_page(struct page *page)
{
wait_queue_head_t *waitqueue = page_waitqueue(page);

[...]

The question now is... what is going on here???

static void i810_free_page(drm_device_t *dev, unsigned long page <-- )
{
struct page * p = virt_to_page(page); <--

What exactly is unsigned long page supposed to be? I sure as hell hope its
an address... if it is, thats a really strange variable naming...

Cheers,
Zwane Mwaikambo

-- 
http://function.linuxpower.ca
		

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/