Re: Strange s390 code in 2.4.19-pre8

Pete Zaitcev (zaitcev@redhat.com)
Mon, 13 May 2002 12:19:33 -0400


> Date: Mon, 13 May 2002 11:16:07 -0500 (CDT)
> From: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>

> > > #2 - strange changes to net Makefile
> > The intention of this is to have fsm.o built as a module if ctc
> > and iucv are built as modules too. I agree that this is broken
> > if one of {iucv,ctc} is built as a module and the other is built
> > in.
>
> Actually, I don't think it's broken, Rules.make takes care of that case
> and compiles fsm.o into the kernel in the latter case, it does not build
> a fsm.o module.
>
> --Kai

Obviously, the guy who did the change expected it to work
like you described, but he never tested it, and it doesn't.
ctc fails to load with init_fsm undefined.
It would work if EXPORT_SYMBOL_NOVERS were involved.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/