Re: [PATCH] 2.5.16 IDE 68

Juan Quintela (quintela@mandrakesoft.com)
22 May 2002 12:48:15 +0200


>>>>> "martin" == Martin Dalecki <dalecki@evision-ventures.com> writes:

martin> Wed May 22 02:56:45 CEST 2002 ide-clean-68
martin> - Make the different ATAPI device type drivers use a unified packet command
martin> structure. We have to start to push them together.

martin> This patch is rather trivial in itself, but the plentora of code duplication it
martin> is trying to fight against is making it unfortunately rather big...

Hi

atapi.c is not a module, then it don't make sense to have a
MODULE_LICENSE :(

Notice that I don't like that kind of trap:

disable IDECD
compile kernel
enable IDECD as module
compile module

your module don't work :(

And we have had already that problem with NFS, please, make that file
_always_ compiled in, or make it a real module.

Later, Juan.

-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/