Re: [PATCH] 2.5.17 IDE 67

[Martin Dalecki]

Uz.ytkownik Tom Rini napisa?:
> On Wed, May 22, 2002 at 09:19:07AM +0200, Martin Dalecki wrote:
> 
> 
>>Wed May 22 01:43:54 CEST 2002 ide-clean-67
>>
>>- Nuke COMMERIAL and similar spurious configuration options...
>>  The fact that every single default configuration option contained
>>  those bits makes this trivial patch appear rather big.
> 
> 
> This also nukes CONFIG_DMA_NONPCI.  While this probably shouldn't have
> been define_bool'ed to 'n' all of the time, there are cases where this
> seems to be properly used.  I know PPC4xx uses it (or will be using it
> once the driver is ready to be submitted) and it looks like cris uses it
> as well.

No I checked. PPC4xx had no functional code for the case
of CONFIG_DMA_NONPCI. It just looked like it had.
Look at the patch and see that it is removing the two
nonpci_xxx functions which are nowhere defined!

And the portability layer provides better mechanisms for the purpose
the serve to serve by the neas of the udma_ interface now.
Please look closer. The __CRIS__ behaviour is preserved and BTW.
not pretty as well.
But this can be fixed a bit later...