Re: [patch] New driver for Artop [Acard] controllers.

[Vojtech Pavlik]

--GvXjxJ+pjyke8COw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 24, 2002 at 05:29:10PM +0200, Vojtech Pavlik wrote:
> On Fri, May 24, 2002 at 04:29:39PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > Hi!
> > 
> > I have a very quick look over patch/driver... looks quite ok...
> > 
> > But it doesn't support multiple controllers. We should add 'unsigned
> > long private' to 'ata_channel struct' and store index in the chipset
> > table there.
> > You can remove duplicate entries from module data table.
> > 
> > BTW: please don't touch pdc202xx.c I am playing with it...
> 
> Here is a new patch. Martin: This one should be OK for inclusion now.
> Bartlomiej: Please check it anyway.

One more fix attached.

-- 
Vojtech Pavlik
SuSE Labs

--GvXjxJ+pjyke8COw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="artop3.diff"

ChangeSet@1.660, 2002-05-24 17:56:40+02:00, [e-mail]
  UDMA33 controller cannot deetct 80-wire cable.

 aec62xx.c |    3 +++
 1 files changed, 3 insertions(+)

diff -Nru a/drivers/ide/aec62xx.c b/drivers/ide/aec62xx.c
--- a/drivers/ide/aec62xx.c	Fri May 24 17:56:57 2002
+++ b/drivers/ide/aec62xx.c	Fri May 24 17:56:57 2002
@@ -223,6 +223,9 @@
 {
 	unsigned char t;
 
+	if (ch->pci_dev->device == PCI_DEVICE_ID_ARTOP_ATP850UF)
+		return 0;
+
 	pci_read_config_byte(ch->pci_dev, AEC_MISC, &t);
 	return ((t & (1 << ch->unit)) ? 0 : 1);
 }

--GvXjxJ+pjyke8COw--