Re: missing bit from signal patches

Stephen Rothwell (sfr@canb.auug.org.au)
Thu, 30 May 2002 22:08:28 +1000


Hi Roman,

On Thu, 30 May 2002 10:04:03 +0200 (CEST) Roman Zippel <zippel@linux-m68k.org> wrote:
>
> On Thu, 30 May 2002, Stephen Rothwell wrote:
>
> > The following should allow the affected architectures to build in
> > 2.5.19 as currently there will be two definitions of
> > copy_siginfo_to_user.
>
> There are other build problems. m68k doesn't compile, because siginfo_t is
> defined after the generic include and the inline functions in there access
> that structure. On the other hand I can't put the include after the
> definition, as it depends on other defines in the include.
> I worked around it with some ugly hacks, but a proper fix would be very
> welcome.

Is the following a more ugly hack than yours?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

diff -ruN 2.5.19-si/include/asm-generic/siginfo.h 2.5.19-si.3/include/asm-generic/siginfo.h --- 2.5.19-si/include/asm-generic/siginfo.h Thu May 30 09:44:38 2002 +++ 2.5.19-si.3/include/asm-generic/siginfo.h Thu May 30 22:04:54 2002 @@ -64,7 +64,11 @@ } _sifields; } siginfo_t; -#endif +#else /* HAVE_ARCH_SIGINFO_T */ + +struct siginfo; + +#endif /* HAVE_ARCH_SIGINFO_T */ /* * How these fields are to be accessed. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/