Re: PATCH/RFC: fix 2.5.20 ramdisk
Martin Dalecki (dalecki@evision-ventures.com)
Tue, 04 Jun 2002 09:54:14 +0200
Russell King wrote:
> On Tue, Jun 04, 2002 at 10:35:25AM +0200, Jens Axboe wrote:
> 
>>On Mon, Jun 03 2002, Russell King wrote:
>>
>>>2.5.20 seems to be incapable of executing binaries in a ramdisk-based
>>>root filesystem.  The ramdisk in question is an ext2fs, with a 1K
>>>block size loaded via the compressed ramdisk loader in do_mounts().
>>>
>>>It appears that, in the case of a 1K block sized filesystem, we attempt
>>>to read two 512-byte sectors into a BIO vector.  The first one is copied
>>>into the first 512 bytes.  The second sector, however, is copied over
>>>the first 512 bytes.  Obviously not what we really want.
>>
>>Looks good.
> 
> 
> Ok, rev. 2, slightly cleaned up:
> 
> --- orig/drivers/block/rd.c	Wed May 29 21:40:26 2002
> +++ linux/drivers/block/rd.c	Tue Jun  4 09:44:21 2002
> @@ -144,6 +144,7 @@
>  {
>  	struct address_space * mapping;
>  	unsigned long index;
> +	unsigned int vec_offset;
Just a small nit. Shouldn't taht be size_t ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/