Re: [PATCH][2.5] Double quote patches part one: drivers 1/2

[Russell King]

On Mon, Jun 10, 2002 at 09:07:17PM -0600, Lightweight patch manager wrote:
> I spent my whole night correcting the double quotes. Someone pointed out 
> yesterday that they had to be corrected. I did a checker script and am now 
> running over the kernel.
> 
> This patch fixes broken double quotes in printk's and asm's.

Not "broken" as such.  Just "new gcc warns".

> +	" subs	%3, %3, #2          \n"
> +	" bmi	2f                  \n"
> +        "1:                         \n"

Yuck.  Yuck yuck yuck yuck yuck.

1. Spaces -> source bloat.
2. No tab at the start of the file -> yuck when reading the ASM.

My preferred way of fixing these in ARM stuff is to add <tab><tab><tab>\n\
to each line (with the appropriate number of tabs.  See
arch/arm/kernel/semaphore.c for an example.

-- 
Russell King ([e-mail])                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html