Re: [ERROR][PATCH] smbfs compilation in 2.5.21

Urban Widmark (urban@teststation.com)
Sun, 16 Jun 2002 19:13:03 +0200 (CEST)


On Sun, 16 Jun 2002, Erik McKee wrote:

> THis is from the bk tree. It's gcc 2.95.3. That solution might be a bettr one
> after all ;) However, would the stringifying done here to get the function
> name in there mess that up?

stringifying?

The whole point of the original change was to not do any string
concatenation of __FUNCTION__, but it is a string already.

However, could you try this change instead:

-# define PARANOIA(f, a...) printk(KERN_NOTICE "%s: " f, __FUNCTION__, ## a)
+# define PARANOIA(f, a...) printk(KERN_NOTICE "%s: " f, __FUNCTION__ , ## a)

Apparently an extra space before the comma before ## is supposed to
matter. Several of the macros I pointed at before already do that.

See also
http://gcc.gnu.org/onlinedocs/gcc-3.1/cpp/Variadic-Macros.html

/Urban

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/