Re: [CHECKER] 37 stack variables >= 1K in 2.4.17

Andries.Brouwer@cwi.nl
Mon, 17 Jun 2002 13:07:04 +0200 (MEST)


From: David Woodhouse <dwmw2@infradead.org>

+int jffs2_prepare_follow_link(struct dentry *dentry, struct nameidata *nd,
+ const char **llink, struct page **ppage)

+ nd->flags |= LOOKUP_KFREE_NEEDED;

Urgh. Don't do that on my behalf - we'll just switch to using
page_follow_link, which to be honest I thought we'd already done --
there were definitely patches for it floating around.

Good. I think it would be worthwhile to find and submit such patches.
Not just for this attempt of mine, but it is generally a good idea
to keep things as uniform as possible.

I think these two ugly bits, and the entire nd argument of
prepare_follow_link can be eliminated, but apart from jffs2
that also requires a little work in proc.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/