Re: [patch] 2.5.22 add __fput for aio

[Linus Torvalds]

On Mon, 17 Jun 2002, Benjamin LaHaise wrote:
>
> This patch splits fput into fput and __fput.  __fput is needed by aio
> to construct a mechanism for performing fput during io completion,
> which typically occurs during interrupt context.

Ehh. Since you _cannot_ do __fput() from an interrupt context, something
is broken.

Possibly the comments.

If aio calls down to __fput() from an interrupt context, then aio is
clearly broken. Yet that's what the comments seem to imply.

The other alternative is that aio only does the book-keeping from
interrupt context, adds the "struct file * to be freed" to some list of
freeable files, and then does __fput() from _non_interrupt_ context on
those files.

Is that was aio actually _does_?

If so, the code may be fine, but the comments are misleading crap and
should be fixed asap.

		Linus