2.5.22 make dep problem with symbol versions

James Bottomley (James.Bottomley@SteelEye.com)
Tue, 18 Jun 2002 15:43:22 -0500


make dep generates broken versioning (actually empty .ver files) if the local
Makefile rule has more than one export-obj. The new rules to generate the
.ver files actually only apply to the first export-obj in the list, and not
the subsequent ones. The fix is to add the prefix correctly (see below).
This finally gives me a working build for 2.5.22.

James

===== Rules.make 1.59 vs edited =====
--- 1.59/Rules.make Mon Jun 10 21:59:33 2002
+++ edited/Rules.make Tue Jun 18 15:14:39 2002
@@ -131,9 +131,9 @@
genksyms_smp_prefix :=
endif

-$(MODVERDIR)/$(real-objs-y:.o=.ver): modkern_cflags := $(CFLAGS_KERNEL)
-$(MODVERDIR)/$(real-objs-m:.o=.ver): modkern_cflags := $(CFLAGS_MODULE)
-$(MODVERDIR)/$(export-objs:.o=.ver): export_flags := -D__GENKSYMS__
+$(addprefix $(MODVERDIR)/,$(real-objs-y:.o=.ver)): modkern_cflags :=
$(CFLAGS_KERNEL)
+$(addprefix $(MODVERDIR)/,$(real-objs-m:.o=.ver)): modkern_cflags :=
$(CFLAGS_MODULE)
+$(addprefix $(MODVERDIR)/,$(export-objs:.o=.ver)): export_flags :=
-D__GENKSYMS__

c_flags = -Wp,-MD,$(depfile) $(CFLAGS) $(NOSTDINC_FLAGS) \
$(modkern_cflags) $(EXTRA_CFLAGS) $(CFLAGS_$(*F).o) \

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/