Re: [PATCH 2.5.22] simple ide-tape.c and ide-floppy.c cleanup

Jens Axboe (axboe@suse.de)
Thu, 20 Jun 2002 07:42:30 +0200


On Wed, Jun 19 2002, Bartlomiej Zolnierkiewicz wrote:

Looks pretty good in general, just one minor detail:

> +
> +/*
> + * ATAPI packet commands.
> + */
> +#define ATAPI_FORMAT_UNIT_CMD 0x04
> +#define ATAPI_INQUIRY_CMD 0x12

[snip]

We already have the "full" list in cdrom.h (GPCMD_*), so lets just use
that. After all, ATAPI_MODE_SELECT10_CMD _is_ the same as the SCSI
variant (and I think the _CMD post fixing is silly, anyone familiar with
this is going to know what ATAPI_WRITE10 means just fine)

Same for request_sense, that is already generalized in cdrom.h as well.

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/